Made Ibexa DXP webpack modules work properly with symlinks #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue that happens when developing frontend code using packages symlinked by Composer.
Issue stems from the fact that subpackage tries to load their own instance of
@symfony/webpack-encore
. Under normal circumstances (without symlinks) the project's one is selected. However, with symlinks, that module is no longer reachable - as it does not appear in any of the parent directories of package directory (since it resides elsewhere entirely).To prevent this issue, I propose that we expect
webpack.config.js
modules exported from the package to be callables instead (in actuality, allow the to be callables). The exported function would expect to receive an instance of Symfony's Encore as first argument. This also ensures that they will actually receive a global Encore object.For QA:
Documentation: