Finished.I appreciate if I hear any feedback #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ibrahimcesar
left a comment
ibrahimcesar
left a comment
There was a problem hiding this comment.
⭐⭐⭐⭐ and half / 5
- Great work
- Remove the comment on division! Is verbose, is a very well known operation and the link is pointing to the Chinese wikipedia, not of much help in this context
- You spot the result right, just cut
that. 6 cosine is always that number -> 1. Test names should be assertive and that is vague - Same for "Other" texts. You could create tests for 'trigonometry' per example.
- Great that you worked your way to 12 tests!
----------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files | 100 | 100 | 100 | 100 |
math.ts | 100 | 100 | 100 | 100 |
----------|---------|----------|---------|---------|-------------------
=============================== Coverage summary ===============================
Statements : 100% ( 18/18 )
Branches : 100% ( 0/0 )
Functions : 100% ( 9/9 )
Lines : 100% ( 18/18 )
================================================================================
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.