Let the user of iced_wgpu::Renderer manually finish/recall the staging belt
#2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bevy 0.15 support has been completed in tasgon/bevy_iced#34, and is blocked by this PR. What is the status of this PR? Are there any changes needed to get this through? |
Azorlogh
force-pushed
the
more-flexible-wgpu-engine
branch
from
22fd4a8 to
4082e39
Compare
|
I updated the PR. Since recent changes the only thing left is the ability to manually finish & recall the staging belt. |
Azorlogh
changed the title
iced_wgpu::Engine to submit the queue themselficed_wgpu::Renderer manually finish/recall the staging belt
|
Actually there is a second change needed 😅 We need to be able to call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iced integration for bevy needs to let Bevy take care of submitting the queue, so it can't call
Renderer::present. But it still needs to callfinish/recallon the staging belt.This adds two methods
Renderer::staging_belt_finishandRenderer::staging_belt_recallto let the user do it manually.