Expand docs for on_link_click in Rich Text #2803
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.14-dev introduces the requirement to set
on_link_clicked
for any rich text. The behaviour was not very intuitive to me, and I don't fully understand all the intricacies.That said, I would not have come to the conclusion to call
on_link_clicked(never)
(primarily because it seems to hold a Some/None value, setting to aSome(Box::new(never))
did not feel intuitive to me) without asking somebody else for help, so documenting this permanently somewhere can't hurt.There's probably a better improvement that can be done somehow. I did consider adding a helper method (
no_link
or something) that does what the documentation suggests, but I also didn't want to add extra potential bloat.