Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand docs for on_link_click in Rich Text #2803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zarthus
Copy link
Contributor

@Zarthus Zarthus commented Feb 9, 2025

0.14-dev introduces the requirement to set on_link_clicked for any rich text. The behaviour was not very intuitive to me, and I don't fully understand all the intricacies.

That said, I would not have come to the conclusion to call on_link_clicked(never) (primarily because it seems to hold a Some/None value, setting to a Some(Box::new(never)) did not feel intuitive to me) without asking somebody else for help, so documenting this permanently somewhere can't hurt.

There's probably a better improvement that can be done somehow. I did consider adding a helper method (no_link or something) that does what the documentation suggests, but I also didn't want to add extra potential bloat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant