Skip to content

runs mix format on changed files#2

Closed
DougReeder wants to merge 1 commit intoicosa-mirror:masterfrom
DougReeder:icosa-mirror-format
Closed

runs mix format on changed files#2
DougReeder wants to merge 1 commit intoicosa-mirror:masterfrom
DougReeder:icosa-mirror-format

Conversation

@DougReeder
Copy link

What?

formats changed files using mix format

Why?

Consistent formatting, as enforced by CI

How to test

  • Go through changes, with whitespace changes suppressed, observe all changes are just formatting

or

  • build and deploy, observe that Icosa integration still

Documentation of functionality

No change to functionality

Alternatives

run mix format lib/ret/media_resolver.ex lib/ret/media_search.ex lib/ret/meta.ex lib/ret_web/controllers/api/v1/media_search_controller.ex lib/ret_web/controllers/page_controller.ex

Copy link

@Exairnous Exairnous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Exairnous
Copy link

Update: looks like this was done before Hubs-Foundation@facd9be so that needs to be taken into account.

@DougReeder
Copy link
Author

Closed in favor of Hubs-Foundation#743

@DougReeder DougReeder closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants