-
Notifications
You must be signed in to change notification settings - Fork 34
Generic system scalar Depends on PR#328 #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
|
This should be ready-to-go, but it depends on an open PR |
|
Job Documentation, step Sync to remote on 33faac6 wanted to post the following: View the site here This comment will be updated on new commits. |
|
You can rebase this PR now that #328 is merged. |
…el cycle problems. Closes idaholab#329
…ed kernel to be more specific.
8f25456 to
33faac6
Compare
|
Job Build test summary, step Build test summary on 33faac6 wanted to post the following: Test summaryCompared against 6319488 in job civet.inl.gov/job/3423721. Added tests
|
simopier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ke7kto, how do you want to tackle this? Do you want to fix the tests or should I start reviewing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change these here unless you expect this PR to change their results (which I do not think it should unless I'm missing something).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change these here unless you expect this PR to change their results (which I do not think it should unless I'm missing something).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change these here unless you expect this PR to change their results (which I do not think it should unless I'm missing something).
Adds a generic system scalar kernel that handles the time-dependent mass balance of system components. Closes #329
Depends on PR#328
Reason
The fuel cycle examples are unwieldy and prone to copy-paste errors. Adding a custom scalar kernel will allow easier extensibility for specific component and system modeling.
Design
A new templated kernel which allows functor inputs and coupled variables to determine the residual. Assumes first-order dependence on "input" variables.
Impact
Re-implements the fuel cycle capabilities in a more explicit way.