Modularized functions for divertor_monoblock input file

[katielygre]

Resolves #332
Added a function for the general time history of a plasma discharge and for use in other functions.
Added variables to define the plasma discharge (ramp time, discharge time, maximum heat flux, maximum tritium flux, etc.)
Used variables to scale and shift the general time plasma function to match the original input file.

[katielygre]

I can't request reviews so I am tagging @simopier @gonuke. Thanks!

[gonuke]

Thanks @katielygre - this will definitely make things more readable. A couple of thoughts here for more clarity, from my perspective...

[gonuke]

Probably makes sense to move this comment to the place where the max flux is defined

[simopier]

Thank you @katielygre!

The tests currently fail because you need to reference the issue in one of your commit message. Something like (Close #332). This is required for SQA reasons; it's not enough to reference the issue number in the description of the PR, you also need it in one of the commit message.

This is why you are getting the pre-check error:

##########################################################################
ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234)
Merge branch 'devel' of https://github.com/katielygre/TMAP8 into test
Merge branch 'idaholab:devel' into devel
Added timing functions for plasma discharge
##########################################################################

[gonuke]

This looks good to me - thanks @katielygre

[simopier]

@katielygre, your precheck failures are:

##########################################################################
ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234)
Merge branch 'devel' of https://github.com/katielygre/TMAP8 into test
added t_in_cycle function, changed function names
added units and defined time durations
Merge branch 'idaholab:devel' into devel
Added timing functions for plasma discharge

ERROR: The following files contain trailing whitespace after applying your patch:
	test/tests/divertor_monoblock/divertor_monoblock.i

Run the "delete_trailing_whitespace.sh" script in your $MOOSE_DIR/scripts directory.
##########################################################################

See my comment above regarding contain a valid ticket reference! (i.e. #1234). You need to dd it in a commit message. You can use git commit --amend to update the commit message.

Check out the guidance provided in the error message above to fix the whitespace issue.
Also, if you work with VSCode, I recommend following those steps to avoid this issue in the future (or even now): https://stackoverflow.com/questions/30884131/remove-trailing-spaces-automatically-or-with-a-shortcut

[moosebuild]

Job Documentation, step Sync to remote on fa58585 wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Coverage, step Generate coverage on fa58585 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

[simopier]

I have additional comments for you, @katielygre, which you can find below.

I also noticed that the heavy test for the divertor monoblock model was failing. You were not predicting the same behavior as before your changes. So I looked more into it and found the issue, which I described here (#339) and fix here (#340). We'll need to wait for this change to be merged before your changes can be merged. As we discuss, your PR should really not change the behavior of the tests.

Also, if you have a bit of time, I would encourage you to do the same changes you do here in the input files divertor_monoblock_physics-single-var.i and divertor_monoblock_physics.i. I know I told you not to at first to keep things simple, but since you are handling this change well and will need to wait for the other PR to get in, you might as well do it all together here with my latest suggestions.

Regarding suggestions, to facilitate incorporating these comments and the following reviews, I suggest going to the Files changed tab and clicking "add to batch" to the suggestions to agree with, and then go to the top of the page and commit all the suggestions. This will automatically close the suggested changes, and will facilitate follow up reviews.

Let me know if you have any questions!

[gonuke]

It looks like you accidentally committed a merge conflict. Fortunately, it's only a single line and it's identical in both cases, so should be easy to fix.

[gonuke]

Uh-oh.... some git problems here....

[moosebuild]

Job Build test summary, step Build test summary on fa58585 wanted to post the following:

Test summary

Compared against 99ed1f6 in job civet.inl.gov/job/3426101.

No change

[simopier]

@katielygre #340 is now merged, so you can now rebase, resolve conflict, and push this branch to update the PR. This should resolve the failing heavy tests.
Let me know if you have any questions.

[simopier]

You are missing a reference to an issue number in a commit message. You should have (Ref. #332) in one of your commit's message. This is why you are failing pre-check right now.