Skip to content

Conversation

@grische
Copy link
Contributor

@grische grische commented Sep 30, 2025

This allows the following syntax to pull in both version 0.3.1 as well as 0.4.0:

[env.windows]
os_name = nt
platform_tag = win_amd64
sys_platform = win32
platform_machine = AMD64
platform_python_implementation = CPython
platform_system = Windows
python_version = 3.12
python_full_version = 3.12.7
implementation_name = cpython

[requirements]
extremeflash = ==0.3.1
extremeflash = ==0.4.0

The old syntax, is still supported, though:

[requirements]
extremeflash = ==0.3.1
               ==0.4.0

The new syntax can be disabled with the flag --enforce-unique-requirements.

@shamilbi
Copy link
Collaborator

Could you please explain the reasoning behind introducing new syntax when the existing one is functioning well?

@grische
Copy link
Contributor Author

grische commented Oct 13, 2025

Could you please explain the reasoning behind introducing new syntax when the existing one is functioning well?

The idea was that one can take several files, e.g. lock file derivatives, and concatenate them without having to worry about collecting previously existing entries in the list.

If this is not something that you'd like here, I can also implement this logic on a higher layer. We just thought that's something that people had asked in the past and it seemed like a very convenient feature.

@grische grische force-pushed the allow-duplicate-requirements branch from 09c845f to f63337b Compare October 14, 2025 08:35
@grische
Copy link
Contributor Author

grische commented Oct 14, 2025

It might be worth though to drop --enforce-unique-requirements. I only added it in case someone requires the old behaviour.

@grische grische force-pushed the allow-duplicate-requirements branch from f63337b to 72f641c Compare October 14, 2025 08:44
@ido50
Copy link
Owner

ido50 commented Oct 17, 2025

Yeah I don't think we need that flag. I have no problem with supporting both syntaxes, seems fine to me.

@grische grische force-pushed the allow-duplicate-requirements branch from 72f641c to c983aa4 Compare October 20, 2025 13:15
@ido50
Copy link
Owner

ido50 commented Dec 29, 2025

Merged it manually, not sure why GitHub doesn't recognize it.

@ido50 ido50 closed this Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants