Skip to content

morgan.ini: max version for at least one [env] #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shamilbi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

morgan.ini: max version for at least one [env] #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions morgan/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,9 @@ def _filter_files(
return files

def _matches_environments(self, fileinfo: dict) -> bool:
if req := fileinfo.get("requires-python", None):
# The Python versions in all of our environments must be supported
req = fileinfo.get("requires-python", None)
if req:
# The Python versions in some of our environments must be supported
# by this file in order to match.
# Some packages specify their required Python versions with a simple
# number (e.g. '3') instead of an actual specifier (e.g. '>=3'),
Expand All @@ -291,12 +292,9 @@ def _matches_environments(self, fileinfo: dict) -> bool:
req = fileinfo["requires-python"] = re.sub(r'([0-9])\.?\*', r'\1', req)
try:
spec_set = packaging.specifiers.SpecifierSet(req)
for supported_python in self._supported_pyversions:
if not spec_set.contains(supported_python):
# file does not support the Python version of one of our
# environments, reject it
return False
except Exception as e:
if not any(spec_set.contains(i) for i in self._supported_pyversions):
return False
except packaging.specifiers.InvalidSpecifier as e:
print(f"\tIgnoring {fileinfo['filename']}: {e}")
return False

Expand Down