Skip to content

Implementation of GHA #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 8, 2025
Merged

Implementation of GHA #546

merged 17 commits into from
Apr 8, 2025

Conversation

PhilippSchmelter
Copy link
Contributor

This pull request introduces a continuous integration (CI) workflow using GitHub Actions and adds scripts to enforce branch naming conventions and handle semantic versioning. The most important changes include setting up the CI workflow, adding a script to check branch names, and registering tasks for semantic versioning.

CI Workflow Setup:

  • .github/workflows/ci.yml: Added a CI workflow configuration that includes steps for checking out the source code, setting up Gradle and Java, building the project, running tests, generating Scala documentation, and deploying to Maven Central.

Branch Naming Convention:

  • gradle/scripts/branchName.gradle: Added a Gradle script to check branch names against predefined patterns to ensure they follow the required naming conventions.

Semantic Versioning:

  • gradle/scripts/semVer.gradle: Registered tasks for currentVersion and devVersion to print the current semantic version and the development version, respectively.

@PhilippSchmelter PhilippSchmelter added enhancement New feature or request ci Related to continuous integration labels Feb 12, 2025
@PhilippSchmelter PhilippSchmelter self-assigned this Feb 12, 2025
@PhilippSchmelter PhilippSchmelter linked an issue Feb 12, 2025 that may be closed by this pull request
@PhilippSchmelter PhilippSchmelter marked this pull request as ready for review February 19, 2025 13:57
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's try this out!

@sebastian-peter
Copy link
Member

Hmm, looks like something can't handle java 17 (class file version 61)

@PhilippSchmelter
Copy link
Contributor Author

Hmm, looks like something can't handle java 17 (class file version 61)

yes, this PR should probably still be a draft pr 😅

@sebastian-peter sebastian-peter marked this pull request as draft March 19, 2025 08:23
@PhilippSchmelter PhilippSchmelter marked this pull request as ready for review April 1, 2025 00:33
@PhilippSchmelter
Copy link
Contributor Author

PhilippSchmelter commented Apr 1, 2025

@sebastian-peter @danielfeismann
The pipeline fails in the “Version Check” step because it clones and executes the main branch, which still uses Gradle 7.0. That version is too old for Java 17 (at least Gradle 7.3 is required), causing the “Unsupported class file major version 61” error. To fix this, you need to update the Gradle Wrapper in main to a more recent version (e.g., Gradle 8.13) or create a new release since dev uses Gradle 8.5.

Took a while to figure this out :D

@sebastian-peter
Copy link
Member

sebastian-peter commented Apr 2, 2025

I updated the gradle version in main, but I think we also need the gradle version functionality there for this to work, right?

Edit: Nevermind, the functionality is there

@PhilippSchmelter
Copy link
Contributor Author

I updated the gradle version in main, but I think we also need the gradle version functionality there for this to work, right?

Edit: Nevermind, the functionality is there

yes we need it :D

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reverse your changes then, so that this is as close as possible to the simona CI? Otherwise, people will wonder why there's differences at some point, although there's no reason

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's give it a try!

@sebastian-peter sebastian-peter merged commit e2fc964 into dev Apr 8, 2025
4 checks passed
@sebastian-peter sebastian-peter deleted the ps/#545-GitHubActions branch April 8, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing GitHub Actions Pipeline
2 participants