Correctly persist EmInput entities in CsvFileSink#1429
Correctly persist EmInput entities in CsvFileSink#1429pierrepetersmeier wants to merge 32 commits intodevfrom
Conversation
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
|
@pierrepetersmeier Could you add a test that reads in the persisted grid and compares it with the original grid? There are some test for grids without ems in |
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
|
Is this complete and only waiting for some review? @pierrepetersmeier |
…ing-a-jointgridcontainer
|
complete :) |
…ing-a-jointgridcontainer # Conflicts: # CHANGELOG.md
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Looks good except only little detail that may can be improved.
@pierrepetersmeier: is that done? Doesn't look like, to be honest :) |
…ing-a-jointgridcontainer
…use test failed with duplicate key exceptions due to shared output files
…while-persisting-a-jointgridcontainer' into pp/#1337-eminputs-arent-written-while-persisting-a-jointgridcontainer
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
I added the legacy energyManagementUnits which somehow got lost in another PR but should be here. However now some test is failing. It would be great if you could have a look on that.
src/test/groovy/edu/ie3/datamodel/io/sink/CsvFileSinkTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/GridIoIT.groovy
Outdated
Show resolved
Hide resolved
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Great, you found it! Just minor improvements on CsvFileSink from my side. Please also have a look on the sonarcube issue and have a look into my previous comments above.
…ing-a-jointgridcontainer
…while-persisting-a-jointgridcontainer' into pp/#1337-eminputs-arent-written-while-persisting-a-jointgridcontainer
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Almost there. I pushed a little addition to the docs and did minor adaptions. Besides that, there are only little things which would be nice to get included.
src/main/java/edu/ie3/datamodel/models/input/container/EnergyManagementUnits.java
Outdated
Show resolved
Hide resolved
| */ | ||
| class GridIoIT extends Specification implements CsvTestDataMeta { | ||
|
|
||
| @Shared |
There was a problem hiding this comment.
what caused these changes?
There was a problem hiding this comment.
For the test isolation.
src/test/groovy/edu/ie3/datamodel/io/source/csv/GridIoIT.groovy
Outdated
Show resolved
Hide resolved
…ing-a-jointgridcontainer # Conflicts: # src/test/groovy/edu/ie3/datamodel/io/sink/CsvFileSinkTest.groovy
3 participants
Resolves #1337