Skip to content

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Jan 7, 2022

Resolves #206

@ckittl ckittl added the bug Something isn't working label Jan 7, 2022
@ckittl ckittl added this to the Version 2.0 milestone Jan 7, 2022
@ckittl ckittl self-assigned this Jan 7, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #207 (02a345c) into master (5db7b5c) will decrease coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #207      +/-   ##
============================================
- Coverage     45.75%   44.66%   -1.09%     
- Complexity      222      223       +1     
============================================
  Files            34       27       -7     
  Lines          1460     1350     -110     
  Branches        187      177      -10     
============================================
- Hits            668      603      -65     
+ Misses          763      717      -46     
- Partials         29       30       +1     
Impacted Files Coverage Δ
...in/java/edu/ie3/util/quantities/EmptyQuantity.java 83.33% <0.00%> (-4.17%) ⬇️
...n/java/edu/ie3/util/io/xmladapter/YearAdapter.java
...ala/edu/ie3/util/quantities/QuantityMatchers.scala
...util/io/xmladapter/StringToIntegerListAdapter.java
.../scala/edu/ie3/util/quantities/QuantityUtils.scala
...ils/src/main/scala/edu/ie3/util/osm/OsmModel.scala
.../src/main/scala/edu/ie3/util/osm/OsmEntities.scala
.../util/io/xmladapter/StringToStringListAdapter.java
...java/edu/ie3/util/quantities/PowerSystemUnits.java 96.15% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da3a3a...02a345c. Read the comment docs.

@ckittl ckittl marked this pull request as ready for review January 7, 2022 11:42
@ckittl ckittl mentioned this pull request Jan 7, 2022
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 60 percent coverage75.00% Coverage (42.10% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

@ckittl ckittl merged commit 5271d07 into master Jan 7, 2022
@ckittl ckittl deleted the ck/#206-fixTests branch January 7, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable tests in CI
2 participants