Skip to content

Conversation

sebastian-peter
Copy link
Member

Resolves #283

@sebastian-peter sebastian-peter added the speed Improves execution speed, leading to shorter runtimes label Jul 22, 2022
@sebastian-peter sebastian-peter self-assigned this Jul 22, 2022
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 100 percent coverage100.00% Coverage (64.70% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #284 (ce1afa0) into main (c41ca86) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #284      +/-   ##
============================================
- Coverage     66.17%   66.14%   -0.03%     
  Complexity      231      231              
============================================
  Files            40       40              
  Lines          1209     1208       -1     
  Branches        117      117              
============================================
- Hits            800      799       -1     
  Misses          376      376              
  Partials         33       33              
Impacted Files Coverage Δ
...utils/src/main/java/edu/ie3/util/geo/GeoUtils.java 88.88% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41ca86...ce1afa0. Read the comment docs.

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@danielfeismann danielfeismann merged commit e1913b5 into main Jul 25, 2022
@danielfeismann danielfeismann deleted the sp/#283-haversine-speedup branch July 25, 2022 14:39
@sebastian-peter sebastian-peter added this to the Version 2.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
speed Improves execution speed, leading to shorter runtimes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary conversion in GeoUtils.calcHaversine
2 participants