Skip to content

Conversation

t-ober
Copy link
Contributor

@t-ober t-ober commented Aug 1, 2022

resolves #288

@t-ober t-ober requested a review from sebastian-peter August 1, 2022 14:55
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #289 (9f8eed1) into main (3045ddb) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #289      +/-   ##
============================================
+ Coverage     66.14%   66.22%   +0.08%     
  Complexity      231      231              
============================================
  Files            40       40              
  Lines          1208     1211       +3     
  Branches        117      117              
============================================
+ Hits            799      802       +3     
  Misses          376      376              
  Partials         33       33              
Impacted Files Coverage Δ
.../scala/edu/ie3/util/quantities/QuantityUtils.scala 93.10% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3045ddb...9f8eed1. Read the comment docs.

@sonarqubegithubprchecks

This comment has been minimized.

1 similar comment
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (64.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for extracting this functionality!

@sebastian-peter sebastian-peter merged commit b2b8a08 into main Aug 1, 2022
@sebastian-peter sebastian-peter deleted the to/#288-add-util-functions branch August 1, 2022 16:13
@sebastian-peter sebastian-peter added this to the Version 2.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer SIMONAs quantity utils
2 participants