Skip to content

Conversation

sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter commented Oct 23, 2022

Resolves #312

Also completed existing tests

Please enhance with further frequently used methods if you know any!

@sebastian-peter sebastian-peter added the enhancement New feature or request label Oct 23, 2022
@sebastian-peter sebastian-peter self-assigned this Oct 23, 2022
@sebastian-peter sebastian-peter changed the title Enhanced RichQuantityDouble with new units and generic method, Enhanced RichQuantityDouble with new units and generic method Oct 23, 2022
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (65.50% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 66.22% // Head: 67.15% // Increases project coverage by +0.92% 🎉

Coverage data is based on head (79dc7c5) compared to base (1bfea68).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #316      +/-   ##
============================================
+ Coverage     66.22%   67.15%   +0.92%     
  Complexity      231      231              
============================================
  Files            40       40              
  Lines          1211     1236      +25     
  Branches        117      117              
============================================
+ Hits            802      830      +28     
+ Misses          376      373       -3     
  Partials         33       33              
Impacted Files Coverage Δ
...java/edu/ie3/util/quantities/PowerSystemUnits.java 96.22% <0.00%> (+0.07%) ⬆️
.../scala/edu/ie3/util/quantities/QuantityUtils.scala 98.76% <0.00%> (+5.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Oct 23, 2022

⚠️ 1 God Class was detected by Lift in this project. Visit the Lift web console for more details.

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@danielfeismann danielfeismann merged commit 7fdb86e into main Oct 23, 2022
@danielfeismann danielfeismann deleted the sp/#312-enance-richquantitydouble branch October 23, 2022 12:16
@sebastian-peter sebastian-peter added this to the Version 2.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance RichQuantityDouble
2 participants