Enrich an existing grid container by EVs and EVCS #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
staudtMarius
requested changes
Aug 25, 2025
| } | ||
|
|
||
| def get_em_uuid(em: bool): | ||
| em_uuid = "fixme" |
|
|
||
| def create_ev_data_dict(this_node): | ||
| ev_uuid = uuid4() | ||
| ev_type_uuid = uuid4() |
There was a problem hiding this comment.
Do you create the associated ev type somewhere?
Comment on lines
+187
to
+189
| def normaldistribution(dist_params): | ||
| normal_variant = normalvariate(dist_params[0], dist_params[1]) | ||
| return max(min(normal_variant, dist_params[3]), dist_params[2]) |
There was a problem hiding this comment.
We should add some documentation to this method to specify the order of the parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #355
merge first
emtocontrolling_emfor allSystemParticipants#338