Added missing minver to solve validation errors due to minver/maxver derivation rules and defaults from RFC8794.#1042
Open
peturingi wants to merge 1 commit intoietf-wg-cellar:masterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes RFC 8794 validation errors in the EBML Matroska schema by ensuring all elements comply with the rule that maxver must be greater than or equal to minver. The schema version is 4, which means elements without explicit minver/maxver attributes default to minver=1 and maxver=4.
- Adds explicit
minver="0"to deprecated elements (those withmaxver="0") to satisfy the constraint - Adds explicit
maxver="5"to version 5 elements (those withminver="5") to satisfy the constraint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 8794