Skip to content

Added missing minver to solve validation errors due to minver/maxver derivation rules and defaults from RFC8794.#1042

Open
peturingi wants to merge 1 commit intoietf-wg-cellar:masterfrom
peturingi:master
Open

Added missing minver to solve validation errors due to minver/maxver derivation rules and defaults from RFC8794.#1042
peturingi wants to merge 1 commit intoietf-wg-cellar:masterfrom
peturingi:master

Conversation

@peturingi
Copy link

@peturingi peturingi commented Dec 9, 2025

RFC 8794

maxver MUST be greater than or equal to minver.

The minver attribute is OPTIONAL. If the minver attribute is not present, then the EBML Element has a minimum version of "1".

The maxver attribute is OPTIONAL. If the maxver attribute is not present, then the EBML Element has a maximum version equal to the value stored in the version attribute of EBMLSchema.

Copilot AI review requested due to automatic review settings December 9, 2025 05:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes RFC 8794 validation errors in the EBML Matroska schema by ensuring all elements comply with the rule that maxver must be greater than or equal to minver. The schema version is 4, which means elements without explicit minver/maxver attributes default to minver=1 and maxver=4.

  • Adds explicit minver="0" to deprecated elements (those with maxver="0") to satisfy the constraint
  • Adds explicit maxver="5" to version 5 elements (those with minver="5") to satisfy the constraint

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants