XEP-0084: User Avatars. Continuation#679
Open
stokito wants to merge 8 commits intoigniterealtime:masterfrom
Open
XEP-0084: User Avatars. Continuation#679stokito wants to merge 8 commits intoigniterealtime:masterfrom
stokito wants to merge 8 commits intoigniterealtime:masterfrom
Conversation
Co-authored-by: Paul Schaub <[email protected]>
stokito
force-pushed
the
ramabit.avatar_2
branch
2 times, most recently
from
1709740 to
84254e6
Compare
stokito
force-pushed
the
ramabit.avatar_2
branch
from
84254e6 to
18530ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces: #332
Rebased on current master, slightly modernized code with new Java features.
Everything else is where is was, so the feature is not complete, I myself can't finish it.
Tested with Gajim and the PNG avatar publishing works, everything else looks like not.
The API looks for me too low level, I found the babbler more clear and convenient.
It also would be great to check API how this implemented in the Gajim's nbxmpp