[sinttest] Check for PEP prerequisite#686
Open
guusdk wants to merge 1 commit intoigniterealtime:masterfrom
Open
[sinttest] Check for PEP prerequisite#686guusdk wants to merge 1 commit intoigniterealtime:masterfrom
guusdk wants to merge 1 commit intoigniterealtime:masterfrom
Conversation
Geolocation, Mood and UserTune functionality depends on the availability of PEP. If the server doesn't support PEP functinality, these tests should throw a TestNotPossible exception.
|
@guusdk: Thanks for your work on the PEP test :) |
Member
|
This approach duplicates code. How about adding to |
Member
Author
|
I see your point, but I am not convinced this change adds much value. The number of tests affected is small, and the duplication avoided is minimal. We would just be wrapping the same PepManager.getInstanceFor(conOne).isSupported() call. Adding I would lean toward keeping it simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geolocation, Mood and UserTune functionality depends on the availability of PEP. If the server doesn't support PEP functinality, these tests should throw a TestNotPossible exception.