codereview #54
Open
codereview #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rostislav3
reviewed
Dec 25, 2019
| import re | ||
| s=input() | ||
| a=re.findall(r'\d+',s) | ||
|
|
There was a problem hiding this comment.
Для початку, треба давати гарні ім'я для змінних, оскільки це спрощує читання коду s краще замінити хоча б на string.По-друге, краще створювати окрему змінну для шаблону і знову ж загально прийнятим ім'ям для шаблону є pattern, рекомендую використовувати його.
|
|
||
| for i in a: | ||
| c=convert_base(i) | ||
| print(c) No newline at end of file |
There was a problem hiding this comment.
Код написаний гарно і логічно, але в очі кидається відсутність пробілів, раджу привчати себе до них.
|
|
||
| list=[1,3,555,[],134,'fjwlijc',[],'random'] | ||
| LS=list.count([]) | ||
| print("Кількість порожніх списків="+str(LS)) No newline at end of file |
There was a problem hiding this comment.
Код написаний гарно і коротко , але раджу не забувати про пробіли.
| Вивести усі слова котрі містять в слові велику букву | ||
| """ | ||
| A=input("Введіть рядок:") | ||
| slova = A.split(" ") |
There was a problem hiding this comment.
"A" , це не коректне ім'я для змінної.
| for i in list: | ||
| if isinstance(i,int): | ||
| sum+=i | ||
| print(sum) No newline at end of file |
There was a problem hiding this comment.
Використовуй пробіли, набагато комфортніше читати код.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.