Skip to content

code review #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tansa25 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

code review #66

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea6e739
upload task1
IvanDanilov03 Dec 23, 2019
ba34d91
fixed name of file
IvanDanilov03 Dec 23, 2019
be687c2
ready for code review
IvanDanilov03 Dec 23, 2019
a60d1ec
Перша контрольна
tansa25 Dec 23, 2019
c664100
Додані умови
tansa25 Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions KornienkoT/first/task1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
lis = [1, 4 ,7 ,"f", [], [], []]
print (lis.count([]))
Copy link

@egorkravchenko13 egorkravchenko13 Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

"""
Порахувати кількість порожніх списків у заданому списку
"""
def task2(lis):
    result = lis.count([])
    return result

Everything is ok
But, without name task

10 changes: 10 additions & 0 deletions KornienkoT/first/task2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
sentence = input()
Copy link

@egorkravchenko13 egorkravchenko13 Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can improve input("Write text: ")

print (sentence)

CapLetters = sentence.split(" ")
print (CapLetters)

for word in CapLetters:
for symb in word:
if (symb.isupper()):
print (word)
Copy link

@egorkravchenko13 egorkravchenko13 Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"""
Вивести слова, які мястять хоча б одну велику букву
"""

def task2(capletters):
    for word in capletters:
        for symb in word:
            if (symb.isupper()):
                return word
print(task2(CapLetters))

Everything is ok
But, without name task

14 changes: 14 additions & 0 deletions KornienkoT/first/task3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
lis = ["h","t", 3, 7, 9, {}]

Copy link

@egorkravchenko13 egorkravchenko13 Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

def task3(lis):
    number = []
    string = []

    for i in lis:
        elem = type(i)
        if (elem == float or elem == int):
            number.append(i)

        elif (elem == str):
            string.append(i)

    print ( sum (number))
print (task3(lis))

number = []
string = []

for i in lis:
elem = type(i)
if (elem == float or elem == int):
number.append(i)

elif (elem == str):
string.append(i)

print ( sum (number))
Copy link

@egorkravchenko13 egorkravchenko13 Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is ok
But, without name task