Skip to content

Fix loading from Downloads folder in Android 9 and above #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hidekisdev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix loading from Downloads folder in Android 9 and above #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 46 additions & 8 deletions simplecropview/src/main/java/com/isseiaoki/simplecropview/util/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.io.InputStream;
import java.util.ArrayList;
import java.util.List;
import java.util.Objects;

import static android.graphics.Bitmap.createBitmap;

Expand Down Expand Up @@ -277,15 +278,52 @@ public static Uri ensureUriPermission(Context context, Intent intent) {
}
// DownloadsProvider
else if (isDownloadsDocument(uri)) {
final String id = DocumentsContract.getDocumentId(uri);
// String "id" may not represent a valid Long type data, it may equals to
// something like "raw:/storage/emulated/0/Download/some_file" instead.
// Doing a check before passing the "id" to Long.valueOf(String) would be much safer.
if (RawDocumentsHelper.isRawDocId(id)) {
filePath = RawDocumentsHelper.getAbsoluteFilePath(id);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
try (Cursor cursor = context.getContentResolver().query(uri, new String[]{MediaStore.MediaColumns.DISPLAY_NAME}, null, null, null)) {
if (cursor != null && cursor.moveToFirst()) {
String fileName = cursor.getString(0);
filePath = Environment.getExternalStorageDirectory().toString() + "/Download/" + fileName;
if (!TextUtils.isEmpty(filePath)) {
return new File(filePath);
}
}
}
String id = DocumentsContract.getDocumentId(uri);
if (!TextUtils.isEmpty(id)) {
if (id.startsWith("raw:")) {
id = id.replaceFirst("raw:", "");
}
String[] contentUriPrefixes = new String[]{
"content://downloads/public_downloads",
"content://downloads/my_downloads"
};
for (String contentUriPrefix : contentUriPrefixes) {
try {
final Uri contentUri = ContentUris.withAppendedId(Uri.parse(contentUriPrefix), Long.valueOf(id));

filePath = getDataColumn(context, contentUri, null, null);
} catch (NumberFormatException e) {
// Android 8 and above, the id is not a long value
filePath = Objects.requireNonNull(uri.getPath()).replaceFirst("^/document/raw:", "").replaceFirst("^raw:", "");
}
}
}

} else {
final Uri contentUri = ContentUris.withAppendedId(Uri.parse("content://downloads/public_downloads"), Long.valueOf(id));
filePath = getDataColumn(context, contentUri, null, null);
String id = DocumentsContract.getDocumentId(uri);
if (id.startsWith("raw:")) {
id = id.replaceFirst("raw:", "");
}
Uri contentUri = null;
try {
contentUri = ContentUris.withAppendedId(
Uri.parse("content://downloads/public_downloads"), Long.valueOf(id));

} catch (NumberFormatException ignored) {
}
if (contentUri != null) {
filePath = getDataColumn(context, contentUri, null, null);
}
}
}
// MediaProvider
Expand Down