Skip to content

Clarifies the matching behavior of assert_called #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/patch.ex
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,22 @@ defmodule Patch do
assert_called Example.function(4, 5, 6) # fails
assert_called Example.function(4, _, 6) # fails
```

If a pattern would match multiple calls, the latest call will be bound.

```elixir
patch(Example, :function, :patch)

Example.function(1, 2, 3)

assert_called Example.function(a, b, c) # passes
IO.inspect([a, b, c]) # prints "[1, 2, 3]"

Example.function(4, 5, 6)
Example.function(7, 8, 9)

assert_called Example.function(a, b, c) # passes
IO.inspect([a, b, c]) # prints "[7, 8, 9]"
"""
@spec assert_called(Macro.t()) :: Macro.t()
defmacro assert_called(call) do
Expand Down
24 changes: 24 additions & 0 deletions test/user/assert_called_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,30 @@ defmodule Patch.Test.User.AssertCalledTest do
assert y == 2
end

test "when multiple calls match the latest is returned" do
patch(AssertCalled, :example, :patched)

assert AssertCalled.example(1, 2) == :patched

assert_called AssertCalled.example(a, b)
assert a == 1
assert b == 2

assert AssertCalled.example(3, 4) == :patched

assert_called AssertCalled.example(a, b)
assert a == 3
assert b == 4


assert AssertCalled.example(5, 6) == :patched
assert AssertCalled.example(7, 8) == :patched

assert_called AssertCalled.example(a, b)
assert a == 7
assert b == 8
end

test "exception formatting with no calls" do
patch(AssertCalled, :example, :patched)

Expand Down
Loading