Skip to content

Jpro refactored ConceptController #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Jpro refactored ConceptController #811

wants to merge 5 commits into from

Conversation

@vollbrecht-work
Copy link
Contributor

@vollbrecht-work vollbrecht-work commented Sep 25, 2025

This is a nearly finished refactor of the ConceptController / ConceptViewModel.

Main features:

  • Streamlined state management ( all inner state is now contained in a ConceptViewModel)
  • Drastically reduces the previously duplicated code - for example such as in the old Semantic FormModels
  • Create symmetry in the codebase with respect to the Pattern / PatternSemantic Window.

@vollbrecht-work
Copy link
Contributor Author

vollbrecht-work commented Sep 25, 2025

this PR would superseed #688 and #727

@vollbrecht-work
Copy link
Contributor Author

vollbrecht-work commented Sep 25, 2025

this PR would also addresses JPRO 213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vollbrecht-work