Curriculum Report #8268
Draft
Curriculum Report #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I be able to add both a Subject and Course new report form widget at the same time? |
|
Thanks for catching that @michaelchadwick, I'd forgotten to put that in my todo notes. Got it now! |
jrjohnson
force-pushed
the
courses-report
branch
2 times, most recently
from
eed6004 to
5038802
Compare
Switched from expand collapse to the same type of dropdown picker we have in other places in the app. User chooses what type of report they'd like to add and then adds it. Courses report super blank right now.
Pick courses to report on and display them.
Pull all the data from the GraphQL API for all of these selected courses and put a summary on the screen. There are some guesses here. I've selected the first offering of ILM to determine start date, for example. Will have to test the output and see if it's correct.
This component was getting pretty huge, let's split the results out into another container.
I wasn't understanding this report. Instead each session objective gets a line, that's the focus of the output.
Adding data for instructors, first offering, and duration to the report and re-doing the query to be course based to fetch all this additional information efficiently.
Instead of searching for a course all of the schools are listed and you pick each course you want to report on from that list.
Moving the subject reports and the list into a tree so we can differentiate the curriculum reports into their own space. This is first step cleanup to get it working, lost more to add to make it good.
This is the new container, just moving everyone over for now and getting rid of some old stuff.
It's not a lot of data and takes less than a few seconds to load. By having it all upfront we avoid loading spinners in the course chooser and screen jumps in the list of selected courses.
Moving buttons around and putting the results OR the course picker on the screen.
Moving the action buttons out of their containers so they appear into the same space when a report is run, even though they're in different levels of the component tree.
Sort the primary school to the top of the list and fixed the HTML structure to be a correct list and not an invalid bunch of tags.
Don't bother showing schools we're not offering to report on. Maintains the fiction that we may have a toggle to show all years at some point, just in case we add it.
This is a more compact way to display the courses that have been selected and fits with the filter pattern we use on the calendar.
Putting the data loading and display into a component like we do for subject reports and now we can choose from a variety of reports (after we build some).
Too much information before, this more reasonably shows the user they're getting the right information together.
Reports on all of the learner groups in a course.
This allows the link to server as the store for running a report, visiting it will give the same result every time.
Selecting the school is better done in a dropdown instead of an expander.
As we're only displaying a few years of courses, we can save everyone load time by just loading those years.
This was very pretty, but caused horrible jumps in the list below it. Ditch it in favor of a summary.
This ensures the route is immediately responsive and has some eye candy as well while the course list is loading.
Only show the name of the report instead.
jrjohnson
force-pushed
the
courses-report
branch
from
5038802 to
dc8e6b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new type of Curriculum report that covers multiple courses. Each report is a separate component so it can control its own data loading, summary, and download.
WIP: