Fix Token Generation #8353
Open
Fix Token Generation #8353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some specific time points (such as between 11pm and midnight we were generating negative numbers which were invalid ISO 8601 periods and would be rejected by the API. Instead of rolling our own we can now use Luxon's built in toIso() method to gather this data.
jrjohnson
requested review from
michaelchadwick and
stopfstedt
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some specific time points (such as between 11pm and midnight we were generating negative numbers which were invalid ISO 8601 periods and would be rejected by the API. Instead of rolling our own we can now use Luxon's built in toIso() method to gather this data.
Fixes ilios/ilios#5976