Merge pull request #74 from stopfstedt/closure_fix

fixes scoping issue with closures by explicitly passing variable into it.
ilios · Jan 22, 2025 · 76fc540 · 76fc540
2 parents 1976184 + d95118d
commit 76fc540
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/edit_form.php b/edit_form.php
@@ -143,7 +143,8 @@ protected function definition(): void {
                             &$processparents,
                             &$learnergroupoptions,
                             &$grouptitle,
-                            &$instance
+                            &$instance,
+                            $ilios
                         ) {
                             $parentgroup = $ilios->get_learner_group($child->parent);
                             $instance->learnergroupid = $parentgroup->id;
@@ -444,7 +445,7 @@ public function definition_after_data(): void {
                                                                    ' ('. count($subgroup->children) .')'.
                                                                    ' ('. count($subgroup->users) .')';
                 if (!empty($subgroup->children)) {
-                    $processchildren = function ($parent) use (&$processchildren, &$subgroupoptions) {
+                    $processchildren = function ($parent) use (&$processchildren, &$subgroupoptions, $ilios) {
                         $subgrps = $ilios->get_learner_groups([ 'parent' => $parent->id], [ 'title' => "ASC"]);
                         foreach ($subgrps as $subgrp) {
                             $subgroupoptions["$subgrp->id:$parent->title / $subgrp->title"] = $parent->title.' / '.$subgrp->title.

diff --git a/version.php b/version.php
@@ -25,7 +25,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version   = 2024110101;       // The current plugin version (Date: YYYYMMDDXX).
+$plugin->version   = 2024110102;       // The current plugin version (Date: YYYYMMDDXX).
 $plugin->requires  = 2024041600;       // Requires this Moodle version.
 $plugin->component = 'enrol_ilios';     // Full name of the plugin (used for diagnostics).
 $plugin->release = 'v4.4';