adds and improves tooltips on the sync instance form#76
Merged
Conversation
stopfstedt
force-pushed
the
improved_tooltips
branch
3 times, most recently
from
January 27, 2025 20:09
ccfbbef to
6ddc1e8
Compare
stopfstedt
marked this pull request as ready for review
January 27, 2025 20:11
this required providing an overwrite of the input field label in the plugin's lang files. see https://docs.moodle.org/dev/lib/formslib.php_Form_Definition#addHelpButton for details.
…new-instance mode. minor cleanup while at it - don't repeat yourself when adding the form elements.
stopfstedt
force-pushed
the
improved_tooltips
branch
from
February 20, 2025 16:45
6ddc1e8 to
21883f4
Compare
stopfstedt
marked this pull request as draft
February 21, 2025 19:34
stopfstedt
force-pushed
the
improved_tooltips
branch
from
February 21, 2025 19:37
d7aa35d to
39cd15d
Compare
stopfstedt
force-pushed
the
improved_tooltips
branch
from
February 21, 2025 19:38
39cd15d to
edd75b3
Compare
jrjohnson
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #75
screenshots of all tooltips - new and old - in the new instance and edit instance forms (spacing between form elements temporarily increased so that tooltips don't overlap in the screenshot.:
Add instance
Edit instance