Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds and improves tooltips on the sync instance form #76

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

stopfstedt
Copy link
Member

@stopfstedt stopfstedt commented Jan 27, 2025

fixes #75

screenshots of all tooltips - new and old - in the new instance and edit instance forms (spacing between form elements temporarily increased so that tooltips don't overlap in the screenshot.:

Add instance

image

image

Edit instance

image

image

@stopfstedt stopfstedt changed the base branch from main to MOODLE_404_STABLE January 27, 2025 18:12
@stopfstedt stopfstedt force-pushed the improved_tooltips branch 3 times, most recently from ccfbbef to 6ddc1e8 Compare January 27, 2025 20:09
@stopfstedt stopfstedt marked this pull request as ready for review January 27, 2025 20:11
this required providing an overwrite of the input field label in the
plugin's lang files.
see
https://docs.moodle.org/dev/lib/formslib.php_Form_Definition#addHelpButton
for details.
…new-instance mode.

minor cleanup while at it - don't repeat yourself when adding the form
elements.
@stopfstedt stopfstedt requested a review from jrjohnson February 21, 2025 19:33
@stopfstedt stopfstedt marked this pull request as draft February 21, 2025 19:34
@stopfstedt stopfstedt removed the request for review from jrjohnson February 21, 2025 19:35
@stopfstedt stopfstedt requested a review from jrjohnson February 21, 2025 19:41
@stopfstedt stopfstedt marked this pull request as ready for review February 21, 2025 21:52
@jrjohnson jrjohnson merged commit 05da6bd into ilios:MOODLE_404_STABLE Feb 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tooltips to input elements in new instance form
2 participants