Colqwen omni #116
Merged
Colqwen omni #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@QuentinJGMace can we merge this ? |
Collaborator
QuentinJGMace
left a comment
QuentinJGMace
left a comment
There was a problem hiding this comment.
Sure, just need to update docstrings (I can do it if needed @ManuelFay :-)
Comment on lines
24
to
28
| class ColQwenOmniRetriever(BaseVisionRetriever): | ||
| """ | ||
| ColQwen2 retriever that implements the model from "ColPali: Efficient Document Retrieval | ||
| with Vision Language Models". | ||
| """ |
Collaborator
There was a problem hiding this comment.
Suggested change
| class ColQwenOmniRetriever(BaseVisionRetriever): | |
| """ | |
| ColQwen2 retriever that implements the model from "ColPali: Efficient Document Retrieval | |
| with Vision Language Models". | |
| """ | |
| class ColQwenOmniRetriever(BaseVisionRetriever): | |
| """ | |
| ColQwenOmni retriever that implements the model from "ColPali: Efficient Document Retrieval | |
| with Vision Language Models" for a Qwen-2.5 Omni backbone. | |
| """ |
Comment on lines
43
to
44
| 'Install the missing dependencies with `pip install "vidore-benchmark[colpali-engine]"` ' | ||
| "to use ColQwen2Retriever." |
Collaborator
There was a problem hiding this comment.
Suggested change
| 'Install the missing dependencies with `pip install "vidore-benchmark[colpali-engine]"` ' | |
| "to use ColQwen2Retriever." | |
| 'Install the missing dependencies with `pip install "vidore-benchmark[colpali-engine]"` ' | |
| "to use ColQwenOmniRetriever." |
QuentinJGMace
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.