-
Notifications
You must be signed in to change notification settings - Fork 33
Add support for token pooling for vision retriever wrapper #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for token pooling for vision retriever wrapper #85
Conversation
b9cde16 to
2c81580
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/retrievers/test_vision_retriever.py:53
- [nitpick] The type annotation 'ColIdefics3Retriever' is inconsistent with the fixture, which instantiates a VisionRetriever. Consider updating the type annotation to match the actual instance returned by the fixture.
def test_forward_queries(self, retriever: ColIdefics3Retriever, queries_fixture):
1a47dcf to
f7e15eb
Compare
QuentinJGMace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me, sorry for the delay
Description
VisionRetrieverclassVisionRetrieverclassExample usage:
Tests (local run)