add p5p archive publisher command #1
Conversation
src/main.rs
Outdated
| pkg(log, &["-R", &mp.to_str().unwrap(), "set-publisher", | ||
| "--no-refresh", | ||
| "--non-sticky", | ||
| &a.publisher, | ||
| ])?; |
There was a problem hiding this comment.
I suspect it would be better to adjust the existing pkg_set_publisher step to do this. You could make the uri argument to that step optional, and add a new optional sticky boolean that if provided would include an appropriate --sticky or --non-sticky argument.
src/main.rs
Outdated
| pkg(log, &["-R", &mp.to_str().unwrap(), "refresh", "--full"])?; | ||
| pkg(log, &["-R", &mp.to_str().unwrap(), "update"])?; |
There was a problem hiding this comment.
We should turn these into separate steps, I think. A pkg_refresh step with an optional full boolean, and a pkg_update step.
There was a problem hiding this comment.
I've been talking to @jclulow about similar things. and feel the need to add that if you just did refresh --full, you probably want to pass --no-refresh to everything else, to avoid doing checks again and again. Here, especially, that seems easy. It might be less easy for every pkg operation (but it would be good!)
src/main.rs
Outdated
| pkg(log, &["-R", &mp.to_str().unwrap(), | ||
| "set-publisher", "-p", &a.archive, "--search-first", | ||
| ])?; |
There was a problem hiding this comment.
This form of set-publisher does a bit of magic when you don't specify a publisher argument, as far as I can tell. Depending on what publishers are in the archive it might end up adding more than one, or updating existing publishers. Is that what you intend?
Also, it seems like the image will contain publisher information that might not make sense once it's installed, unless you ship the archive at the exact same location inside the final image.
Did you try a version of this that used the temporary archive functionality; i.e., something like pkg update -g $ARCHIVE_PATH ? You would still need to have set the existing publisher(s) non-sticky I believe.
There was a problem hiding this comment.
The intention is to add the packages from the archive as the packages with the highest priority.
In the builds that I have that use this machinery, yes, I am shipping the p5p archive at the exact location it's used from here. The intent is to ship the archive to its expected/installed location.
I did try the pkg install -g $ARCHIVE_PATH * route. The packages I'm using this for are ONU builds, and this avenue did not go well.
|
Thanks for the feedback @jclulow. I've broken up the pkg_set_p5p_publisher command as you suggested and provided some more context on the last question. |
This allows custom p5p archives to be included in the image build process.