-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Implement Thread-Pool Executor pattern #3271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR SummaryThis PR implements the Thread-Pool Executor pattern using a hotel front desk example. It includes a Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
-
b83a609: feat: Implement Thread-Pool Executor pattern
-
Add implementation of Thread-Pool Executor pattern using hotel front desk example
-
Include unit tests
-
Create detailed README with pattern explanation and examples
-
Add Java source code with appropriate Javadoc comments
Closes #3226
Files Processed (13)
- pom.xml (1 hunk)
- thread-pool-executor/README.md (1 hunk)
- thread-pool-executor/etc/thread-pool-executor.urm.png (0 hunks)
- thread-pool-executor/etc/thread-pool-executor.urm.puml (1 hunk)
- thread-pool-executor/pom.xml (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/App.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/FrontDeskService.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/GuestCheckInTask.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/VipGuestCheckInTask.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/AppTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/FrontDeskServiceTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/GuestCheckInTaskTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/VipGuestCheckInTaskTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
pom.xml
Outdated
@@ -245,6 +245,7 @@ | |||
<module>visitor</module> | |||
<module>backpressure</module> | |||
<module>actor-model</module> | |||
<module>thread-pool-executor</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cosmetic: why not putting it in alphabetic order? 😉 also, indentation seems off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review!
I currently working on fixing the Sonarqube issues in the code, so I'll address these formatting problems too.
b83a609
to
7f2f1fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
-
7f2f1fd: feat: Implement Thread-Pool Executor pattern
-
Add implementation of Thread-Pool Executor pattern using hotel front desk example
-
Include unit tests
-
Create detailed README with pattern explanation and examples
-
Add Java source code with appropriate Javadoc comments
Closes #3226
Files Processed (13)
- pom.xml (1 hunk)
- thread-pool-executor/README.md (1 hunk)
- thread-pool-executor/etc/thread-pool-executor.urm.png (0 hunks)
- thread-pool-executor/etc/thread-pool-executor.urm.puml (1 hunk)
- thread-pool-executor/pom.xml (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/App.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/FrontDeskService.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/GuestCheckInTask.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/VipGuestCheckInTask.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/AppTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/FrontDeskServiceTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/GuestCheckInTaskTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/VipGuestCheckInTaskTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
7f2f1fd
to
3d8fa01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
-
3d8fa01: feat: Implement Thread-Pool Executor pattern
-
Add implementation of Thread-Pool Executor pattern using hotel front desk example
-
Include unit tests
-
Create detailed README with pattern explanation and examples
-
Add Java source code with appropriate Javadoc comments
Closes #3226
Files Processed (13)
- pom.xml (1 hunk)
- thread-pool-executor/README.md (1 hunk)
- thread-pool-executor/etc/thread-pool-executor.urm.png (0 hunks)
- thread-pool-executor/etc/thread-pool-executor.urm.puml (1 hunk)
- thread-pool-executor/pom.xml (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/App.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/FrontDeskService.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/GuestCheckInTask.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/VipGuestCheckInTask.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/AppTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/FrontDeskServiceTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/GuestCheckInTaskTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/VipGuestCheckInTaskTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
- Add implementation of Thread-Pool Executor pattern using hotel front desk example - Include unit tests - Create detailed README with pattern explanation and examples - Add Java source code with appropriate Javadoc comments Closes iluwatar#3226
3d8fa01
to
3ac5ce7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
-
3ac5ce7: feat: Implement Thread-Pool Executor pattern
-
Add implementation of Thread-Pool Executor pattern using hotel front desk example
-
Include unit tests
-
Create detailed README with pattern explanation and examples
-
Add Java source code with appropriate Javadoc comments
Closes #3226
Files Processed (13)
- pom.xml (1 hunk)
- thread-pool-executor/README.md (1 hunk)
- thread-pool-executor/etc/thread-pool-executor.urm.png (0 hunks)
- thread-pool-executor/etc/thread-pool-executor.urm.puml (1 hunk)
- thread-pool-executor/pom.xml (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/App.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/FrontDeskService.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/GuestCheckInTask.java (1 hunk)
- thread-pool-executor/src/main/java/com/iluwatar/threadpoolexecutor/VipGuestCheckInTask.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/AppTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/FrontDeskServiceTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/GuestCheckInTaskTest.java (1 hunk)
- thread-pool-executor/src/test/java/com/iluwatar/threadpoolexecutor/VipGuestCheckInTaskTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
|
Pull Request Template
What does this PR do?
This PR implements the Thread-Pool Executor pattern, which demonstrates how a pool of worker threads can be used to execute tasks concurrently. It includes a complete implementation with a hotel front desk example, comprehensive tests, and detailed documentation.
Key Features
Related Issue
Closes #3226