-
Notifications
You must be signed in to change notification settings - Fork 6
feat: implement perspective warp #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 98.62% 98.66% +0.03%
==========================================
Files 244 246 +2
Lines 10347 10645 +298
Branches 2141 2170 +29
==========================================
+ Hits 10205 10503 +298
Misses 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Currently, there is only the test case from the issue but the implementation right now seems to be identical to the openCV implementation when nearest neighbor interpolation is used. Besides adding more test cases, should there be an option that allows the choice of interpolation? |
The initial idea was to implement a function which returns a transform matrix like OpenCV does, and to use that transform matrix to create the new image using The |
There is a function in legacy version that calculates width and height with respect of image's aspect ratio. Is it okay to remove the function that calculates width and height to preserve ratio of the image and just specify desired width and height? openCV version doesn't have one, you need to put destination corner points there. We could do a function with 4 source points and 4 destination points. |
Also the transform() function currently accepts 2x3 matrices for affine transformations. Should i modify the code so that it accepts only 3x3 matrices or it should accept both, and if input matrix is 2x3 i just add another row? After all, if i understand correcly, affine transformation is perspective transformation with [0,0,1] as last matrix row |
After discussion with @stropitek we decided to have a |
056803f
to
04520ab
Compare
073c889
to
be89641
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the script which generated the images transformed by opencv to generate.py
?
What are the new exported APIs? It does not seem that you export the new functionalities.
57e7b56
to
e03ad0b
Compare
3c38dcb
to
d77815e
Compare
38b9a28
to
193a8d8
Compare
85bef08
to
2469e0c
Compare
No description provided.