Make Kernel::new constant
#648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It’s a shame to lose the useful panic message but not the end of the world - I can’t imagine it’s likely that anyone will ever be constructing a Kernel in ways that make it hard to work out the dimensions required. |
ripytide
reviewed
May 26, 2024
| height: 3, | ||
| }; | ||
| pub const FOUR_LAPLACIAN_3X3: Kernel<'static, i16> = | ||
| Kernel::new(&[1, 1, 1, 1, -4, 1, 1, 1, 1], 3, 3); |
There was a problem hiding this comment.
I think I typed this one wrong as well, it's supposed to have zeros in the corners, whoops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may also need a static
Kernel!