add pHash
#709
Merged
add pHash
#709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know there are possible optimizations. It's a starting point. |
Cargo.toml
Outdated
| @@ -54,6 +55,9 @@ features = ["property-testing", "katexit"] | |||
| opt-level = 3 | |||
| debug = true | |||
|
|
|||
| [profile.dev] | |||
| opt-level = 2 | |||
There was a problem hiding this comment.
What’s the reason for this change? It would be a shame to make debug builds take even longer.
There was a problem hiding this comment.
To speed up proptests
There was a problem hiding this comment.
Changed to opt-level = 1
src/imghash/mod.rs
Outdated
| //! [Perceptual hashing] algorithms for images. | ||
| //! | ||
| //! [Perceptual hashing]: https://en.wikipedia.org/wiki/Perceptual_hashing | ||
|
|
There was a problem hiding this comment.
The rest of this library uses “image” over “img” for module and function names - please can you rename this to image_hash or maybe perceptual_hashing.
There was a problem hiding this comment.
renamed to image_hash
|
I updated MSRV because |
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #703