Test xarray naming post conversion and enable GUI tests #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_legacy.py
Outdated
Comment on lines
150
to
151
| def test_linked_dataset_convertsion_to_xarray(ij, xarr): | ||
| ensure_legacy_enabled(ij) |
There was a problem hiding this comment.
The word 'convertsion' in the test function name is misspelled; consider renaming it to 'conversion'.
Suggested change
| def test_linked_dataset_convertsion_to_xarray(ij, xarr): | |
| ensure_legacy_enabled(ij) | |
| def test_linked_dataset_conversion_to_xarray(ij, xarr): |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Thanks! Do you respond to replies? Good catch on the typo, but the suggestion deletes a line that is necessary.
Legacy tests are always skipped because no framebuffer is available.
Note that I may need to interactive mode for testing conditional on the platform (i.e. macOS does not support interactive mode).
Showing a Dataset and modifying it is not enough. We need to next obtain an ImagePlus via the WindowManager and sync it.
elevans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We merged #323, but we don't have a great test for the fix that reproduced the error, partially because running the test (on CI) would require xvfb. @elevans said he'd look into that - this change should be verified (and merged) after that.