Skip to content

[Fix] Home login qa #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kimjw2003 merged 2 commits into from
Jan 23, 2026
Merged

[Fix] Home login qa #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32a4932
fix: design qa
kimjw2003 Jan 23, 2026
26d801f
fix: plan qa
kimjw2003 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/src/main/java/com/flint/presentation/home/HomeScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ fun HomeRoute(
when (sideEffect) {
is HomeSideEffect.ShowOttListBottomSheet -> {
ottListModel = sideEffect.ottListModel
showOttListBottomSheet = true

if(ottListModel.otts.isNotEmpty()) {
showOttListBottomSheet = true
}
Comment on lines 68 to +73
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

โš ๏ธ Potential issue | ๐ŸŸก Minor

๋นˆ OTT ๋ฆฌ์ŠคํŠธ์ผ ๋•Œ ๋ฐ”ํ…€์‹œํŠธ ์ƒํƒœ ์ดˆ๊ธฐํ™”๊ฐ€ ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค.

ํ˜„์žฌ๋Š” otts๊ฐ€ ๋น„์–ด์žˆ์„ ๋•Œ showOttListBottomSheet๋ฅผ ๊ฐฑ์‹ ํ•˜์ง€ ์•Š์•„, ์ด์ „ ์ƒํƒœ๊ฐ€ true์ธ ๊ฒฝ์šฐ ๋นˆ/์ด์ „ ๋ฐ์ดํ„ฐ๋กœ ์‹œํŠธ๊ฐ€ ์œ ์ง€๋  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ๋ฆฌ์ŠคํŠธ ์ƒํƒœ์™€ ์‹œํŠธ ๋…ธ์ถœ์„ ํ•ญ์ƒ ๋™๊ธฐํ™”ํ•˜๋Š” ํŽธ์ด ์•ˆ์ „ํ•ฉ๋‹ˆ๋‹ค.

โœ… ์ œ์•ˆ ์ˆ˜์ • 
 ottListModel = sideEffect.ottListModel
-
-if(ottListModel.otts.isNotEmpty()) {
-    showOttListBottomSheet = true
-}
+showOttListBottomSheet = ottListModel.otts.isNotEmpty()
๐Ÿ“ Committable suggestion

โ€ผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
is HomeSideEffect.ShowOttListBottomSheet -> {
ottListModel = sideEffect.ottListModel
showOttListBottomSheet = true
if(ottListModel.otts.isNotEmpty()) {
showOttListBottomSheet = true
}
is HomeSideEffect.ShowOttListBottomSheet -> {
ottListModel = sideEffect.ottListModel
showOttListBottomSheet = ottListModel.otts.isNotEmpty()
๐Ÿค– Prompt for AI Agents 
In `@app/src/main/java/com/flint/presentation/home/HomeScreen.kt` around lines 68
- 73, Summary: Bottom sheet visibility isn't reset when otts is empty, leaving
the sheet visible with stale data. Fix: In the
HomeSideEffect.ShowOttListBottomSheet handling, always assign ottListModel =
sideEffect.ottListModel and then set showOttListBottomSheet based on the actual
list content (e.g., showOttListBottomSheet = ottListModel.otts.isNotEmpty()), so
the sheet is closed when otts is empty and stays synced with ottListModel.

}
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/flint/presentation/home/component/HomeFab.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ fun HomeFab(
modifier
.clip(CircleShape)
.background(FlintTheme.colors.gradient400Secondary)
.size(48.dp)
.size(56.dp)
.clickable { onClick() },
contentAlignment = Alignment.Center,
) {
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/com/flint/presentation/login/LoginScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ fun LoginScreen(
Modifier
.fillMaxWidth()
.align(Alignment.BottomCenter)
.padding(bottom = 60.dp)
.padding(horizontal = 16.dp),
.padding(bottom = 108.dp)
.padding(horizontal = 20.dp),
onClick = {
onKakaoLoginClick()
},
Expand Down
5 changes: 4 additions & 1 deletion app/src/main/java/com/flint/presentation/login/component/KakaoLoginButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.offset
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Text
Expand Down Expand Up @@ -44,7 +45,9 @@ fun KakaoLoginButton(
text = "์นด์นด์˜ค๋กœ ์‹œ์ž‘ํ•˜๊ธฐ",
style = FlintTypography.body1M16,
color = FlintTheme.colors.background,
modifier = Modifier.align(Alignment.Center),
modifier = Modifier
.align(Alignment.Center)
.offset(x = 8.dp),
)
}
}
Expand Down