Skip to content

fix/#188 컬렉션 생성 시 빈 값 전송 및 문구 수정 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nahy-512 merged 3 commits into from
Jan 23, 2026
Merged

fix/#188 컬렉션 생성 시 빈 값 전송 및 문구 수정 #192

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c2ee90
fix: 컬렉션 생성 시 빈 값 전송 및 문구 수정
chanmi1125 Jan 23, 2026
9cabd15
[Feat] 포커스 해제 및 키보드 숨김 처리
chanmi1125 Jan 23, 2026
d829f77
Merge remote-tracking branch 'origin/develop' into fix/#188-collectio…
chanmi1125 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/src/main/java/com/flint/presentation/collectioncreate/CollectionCreateScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ fun CollectionCreateScreen(
verticalAlignment = Alignment.CenterVertically,
) {
Text(
text = "최대 10개까지 추가할 수 있어요",
text = "작품을 2개 이상 추가해주세요.",
color = FlintTheme.colors.gray200,
style = FlintTheme.typography.body2R14,
)
Expand Down Expand Up @@ -305,7 +305,8 @@ fun CollectionCreateScreen(
modifier =
Modifier
.fillMaxWidth()
.defaultMinSize(minHeight = 80.dp),
.defaultMinSize(minHeight = 80.dp)
// .height(100.dp),
Copy link
Contributor

@giovannijunseokim giovannijunseokim Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1: 여기 변경사항 없어져도 될 것 같아요. 작품 추가하기 버튼의 레이아웃은 제 PR에서 수정했습니다!

feat: 작품 추가하기 버튼 위 아래 넓이 확인 한번 해주세요 살짝 좁은 느낌입니다.

)

Spacer(Modifier.height(36.dp))
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/java/com/flint/presentation/collectioncreate/CollectionCreateViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ class CollectionCreateViewModel @Inject constructor(
viewModelScope.launch {
val requestModel = CollectionCreateRequestModel(
imageUrl = "",
title = uiState.value.title.ifBlank { "더미 컬렉션 제목" },
description = uiState.value.description.ifBlank { "더미 설명" },
title = uiState.value.title.ifBlank { "" },
description = uiState.value.description.ifBlank { "" },
Copy link
Contributor

@nahy-512 nahy-512 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1
이거 title, description이 없을 때 빈 문자열로 초기화되는 거 , ifBlank 설정을 따로 해주는 이유가 있을까요?
title은 안 들어가면 막힐거고, description은 빈 문자열 그대로 넣으면 되는 거 아닌가요

Copy link
Contributor Author

@chanmi1125 chanmi1125 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네!! 반영하겠습니다앙

isPublic = uiState.value.isPublic ?: true,
contentList = uiState.value.selectedContents.map { content ->
val detail = uiState.value.contentDetailsMap[content.id] ?: ContentDetail()
CollectionCreateContentModel(
contentId = content.id,
isSpoiler = detail.isSpoiler,
reason = detail.reason.ifBlank { "추천합니다" },
reason = detail.reason.ifBlank { "" },
)
},
)
Expand Down