fix/test: DistanceTransform array out of bounds exception#109
Merged
axtimwalde merged 2 commits intomasterfrom Mar 18, 2025
Merged
fix/test: DistanceTransform array out of bounds exception#109axtimwalde merged 2 commits intomasterfrom
axtimwalde merged 2 commits intomasterfrom
Conversation
Contributor
bogovicj
commented
Mar 6, 2025
- adds tests that reproduce the error in DistanceTransform throws Exception with certain weights #108
* both for distance and voronoiDistance transforms * use primitive arrays rather than RealComposites * get between 40% and 100% speedup
Contributor
Author
|
The second commit to this PR substantially speeds things up (40% - 100%) by using primitive arrays for parts of the lowest level methods Because this implementation makes an attempt to support very large images, we fall back to the old implementation if any dimension is longer than That commit also includes a benchmark, some of the results of which are shown below. Note: there is certainly room for more optimization, but this covers some relatively low-hanging fruit. Selected benchmark results2Dold single threadnew single threadold multi-thread (8)new multi-thread (8)3Dold single threadednew single threaded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.