Skip to content

Add HessianMatrix and TensorEigenValues #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2017
Merged

Add HessianMatrix and TensorEigenValues #41

merged 1 commit into from
May 17, 2017

Conversation

hanslovsky
Copy link
Member

  • Use PartialDerivative to generate linear representation of upper
    triangular Hessian matrix
  • Add TensorEigenValues class to compute eigenvalues on tensors such as
    the Hessian matrix included in this commit.hessian eigenvalues

This pull request rebases all commits in and closes #29.

 - Use PartialDerivative to generate linear representation of upper
   triangular Hessian matrix
 - Add TensorEigenValues class to compute eigenvalues on tensors such as
   the Hessian matrix included in this commit.hessian eigenvalues
@tpietzsch tpietzsch merged commit c51c6e9 into imglib:master May 17, 2017
@tpietzsch
Copy link
Member

thanks @hanslovsky, great work!

@tpietzsch
Copy link
Member

tpietzsch commented May 17, 2017

@hanslovsky Can you please fix the javadoc

[ERROR] /home/travis/build/imglib/imglib2-algorithm/src/main/java/net/imglib2/algorithm/linalg/matrix/RealCompositeMatrix.java:47: error: reference not found
[ERROR] *         {@link RealMatrix} that reads data from {@link Composite} (non-copy).
[ERROR] ^
[ERROR] /home/travis/build/imglib/imglib2-algorithm/src/main/java/net/imglib2/algorithm/linalg/matrix/RealCompositeSquareMatrix.java:44: error: reference not found
[ERROR] *         Square {@link RealMatrix} that reads data from {@link Composite}
[ERROR] ^
[ERROR] /home/travis/build/imglib/imglib2-algorithm/src/main/java/net/imglib2/algorithm/linalg/matrix/RealCompositeSymmetricMatrix.java:44: error: reference not found
[ERROR] *         Symmetric {@link RealMatrix} that reads data from {@link Composite}

I guess, RealMatrix is left over from before ojAlgo?
(Just fix and push on master)

@hanslovsky
Copy link
Member Author

Yes, that was from before ojAlgo, I will fix it.
I tried to ensure that it builds running mvn clean build before creating the final PR but that was not enough, apparently. What maven command would I need to run to replicate the behavior on travis? Probably a question for @ctrueden

@tpietzsch
Copy link
Member

mvn javadoc:javadoc

hanslovsky added a commit that referenced this pull request May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants