Skip to content

fix: improve higher order type inference for WritableDraft - #1205

Merged
mweststrate merged 3 commits into
immerjs:mainfrom
unional:defer-type-inference
May 6, 2026
Merged

fix: improve higher order type inference for WritableDraft#1205
mweststrate merged 3 commits into
immerjs:mainfrom
unional:defer-type-inference

Conversation

@unional

@unional unional commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Fix the issue mentioned in #1197 (comment)

@coveralls

coveralls commented Jan 19, 2026

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 21156723681

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.941%

Totals Coverage Status
Change from base Build 20569346562: 0.0%
Covered Lines: 1687
Relevant Lines: 4781

💛 - Coveralls

@unional
unional force-pushed the defer-type-inference branch from 48fcc8f to d422304 Compare January 20, 2026 01:49

@aryaemami59 aryaemami59 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to resolve the issue. We could add some type tests to be sure, but overall it looks good to me.

@unional
unional force-pushed the defer-type-inference branch from b2cc8c2 to 3c29663 Compare April 10, 2026 16:10
@mweststrate
mweststrate merged commit 7390d6c into immerjs:main May 6, 2026
1 check passed
@mweststrate

Copy link
Copy Markdown
Collaborator

Ugh, merge somehow went wrong, should hopefully have gone through now. THanks!

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 11.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants