Feature: add Form Field Manager license UI to additional fields placeholder #7814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +67,7 @@ public function storageData(int $donationFormId): array | |||
| ], | |||
| 'formFieldManagerData' => [ | |||
| 'isInstalled' => defined('GIVE_FFM_VERSION'), | |||
| 'isLicensed' => (bool) Give_License::get_license_by_plugin_dirname('give-form-field-manager'), | |||
There was a problem hiding this comment.
I think this returns data about the license. Do we need to check if the license is valid or anything?
There was a problem hiding this comment.
Good point, yea we should. 55d9685
jonwaldstein
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1011
Description
This PR updates the additional fields placeholderr UI to consider users that may have a valid license that includes form-field-manager but have not yet installed it.
Affects
Donation Form Builder -> left sidebar blocks
Visuals
Testing Instructions
all_access_passpass & FFM not installed -> you should see the conditional UI with a link directing user to download their additional fields from Givrwp.com.Note: all_access_pass is given to users with Plus, Pro & Agency plans.
Pre-review Checklist
@unreleasedtags included in DocBlocks