Skip to content

i18n: add new strings, update owners, fix notify script#1448

Merged
dumbmoron merged 3 commits intomainfrom
i18n-update
Apr 28, 2026
Merged

i18n: add new strings, update owners, fix notify script#1448
dumbmoron merged 3 commits intomainfrom
i18n-update

Conversation

@dumbmoron
Copy link
Copy Markdown
Member

@dumbmoron dumbmoron commented Apr 25, 2026 •
edited
Loading

If you speak any of these languages, please leave a comment whether the translation looks good, or use the "files changed" feature to suggest changes.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 25, 2026

Reviews (1): Last reviewed commit: "i18n: add new strings" | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2026 •
edited by dumbmoron
Loading

Translation review requested: @Bellisario @Xiang-CH @cheddZy @erdemoon @ferivoq @frknnay @loukhin @niewiemczego

@niewiemczego
Copy link
Copy Markdown
Contributor

niewiemczego commented Apr 25, 2026

LGTM for pl

darkexplosiveqwx
darkexplosiveqwx suggested changes Apr 25, 2026
View reviewed changes
Comment thread i18n/translations/de.json Outdated
cheddZy
cheddZy reviewed Apr 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cheddZy cheddZy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hebrew suggestions

Edit: Sorry, I'll resubmit these with file change suggestions.

Comment thread i18n/translations/he.json Outdated
Comment thread i18n/translations/he.json Outdated
Comment thread i18n/translations/he.json Outdated
Comment thread i18n/translations/he.json Outdated
loukhin
loukhin reviewed Apr 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@loukhin loukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other Thai translations look good, only these two need adjustment

Comment thread i18n/translations/th.json Outdated
Comment thread i18n/translations/th.json Outdated
@Bellisario
Copy link
Copy Markdown
Contributor

Bellisario commented Apr 25, 2026

LGTM for Italian!

Xiang-CH
Xiang-CH approved these changes Apr 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Xiang-CH Xiang-CH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zh-cn looks good

erdemoon
erdemoon approved these changes Apr 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@erdemoon erdemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turkish translation LGTM.

loukhin
loukhin approved these changes Apr 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@loukhin loukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Thai translations

zemiakx
zemiakx reviewed Apr 26, 2026
View reviewed changes
Comment thread i18n/translations/es.json Outdated
zemiakx
zemiakx reviewed Apr 26, 2026
View reviewed changes
Comment thread i18n/translations/ca.json Outdated
zemiakx
zemiakx reviewed Apr 26, 2026
View reviewed changes
Comment thread i18n/translations/ca.json Outdated
@zemiakx
Copy link
Copy Markdown
Contributor

zemiakx commented Apr 26, 2026

Spanish and Catalan LGTM, also I would like to be reviewer for both languages, that way I can get notified to make new changes on time

eduqr
eduqr reviewed Apr 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@eduqr eduqr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change for spanish LATAM, rest LGTM

Comment thread i18n/translations/es-419.json Outdated
@arcabotai
Copy link
Copy Markdown

arcabotai commented Apr 27, 2026

Spanish review (es and es-419): LGTM.

I checked the 8 new strings in both files:

  • custom avatar file picker / clear dialog / size and load errors
  • custom avatar label
  • rounded frame setting
  • sidebar / top bar visibility settings

The translations read natural, preserve the source meaning, use appropriate UI register, and there are no placeholders to preserve in this batch. I would keep them as-is.

@dralan71
Copy link
Copy Markdown
Contributor

dralan71 commented Apr 27, 2026

es and LATAM es lgtm

dralan71
dralan71 reviewed Apr 27, 2026
View reviewed changes
Comment thread i18n/translations/pt-BR.json Outdated
dralan71
dralan71 reviewed Apr 27, 2026
View reviewed changes
Comment thread i18n/translations/pt-BR.json Outdated
@dralan71
Copy link
Copy Markdown
Contributor

dralan71 commented Apr 27, 2026

Aside from the changes above, Brazilian Portuguese looks good to me as well

@AnkanMisra
Copy link
Copy Markdown
Contributor

AnkanMisra commented Apr 27, 2026

Apart from those 2 inconsistencies, the Bengali/Assamese version LGTM

@dumbmoron
Copy link
Copy Markdown
Member Author

dumbmoron commented Apr 27, 2026

@AnkanMisra I don't see any suggestions; maybe you have a pending review and it needs to be submitted?

@AnkanMisra
Copy link
Copy Markdown
Contributor

AnkanMisra commented Apr 27, 2026

@dumbmoron sorry, I was re-reading the json, just submitted the pending review, the suggestions should be visible now

AnkanMisra
AnkanMisra reviewed Apr 27, 2026
View reviewed changes
Comment thread i18n/translations/as.json Outdated
Comment thread i18n/translations/as.json Outdated
AnkanMisra
AnkanMisra reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AnkanMisra AnkanMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this 1 inconsistency, the hindi version also lgtm

Comment thread i18n/translations/hi.json Outdated
ferivoq
ferivoq approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ferivoq ferivoq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Hungarian ones are all accurate in my opinion

@dumbmoron dumbmoron requested a review from wukko April 27, 2026 19:57
wukko
wukko previously approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@wukko wukko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you everyone!

dumbmoron and others added 2 commits April 28, 2026 07:09
@dumbmoron @cheddZy
@loukhin @darkexplosiveqwx @zemiakx @eduqr @dralan71 @AnkanMisra
i18n: add new strings
7bd090f 
Co-authored-by: Shachar MW <53349272+cheddZy@users.noreply.github.com>
Co-authored-by: Supakit Khawmeewong <loukhin@lop.town>
Co-authored-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Co-authored-by: Miguel <m.costa.torre.2005@gmail.com>
Co-authored-by: Eduardo R <128652323+eduqr@users.noreply.github.com>
Co-authored-by: Alan C <alancalsar17@gmail.com>
Co-authored-by: Ankan Misra <misra13arko@gmail.com>
@dumbmoron
ci: fix i18n notify pipeline
0540940
@dumbmoron dumbmoron changed the title i18n: add new strings i18n: add new strings, update owners, fix notify script Apr 28, 2026
@dumbmoron dumbmoron changed the title i18n: add new strings, update owners, fix notify script i18n: add new strings and owners, fix notify script Apr 28, 2026
@dumbmoron dumbmoron changed the title i18n: add new strings and owners, fix notify script i18n: add new strings, update owners, fix notify script Apr 28, 2026
@dumbmoron dumbmoron merged commit 1ae83af into main Apr 28, 2026
10 checks passed
@dumbmoron dumbmoron deleted the i18n-update branch April 28, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wukko wukko wukko approved these changes

+11 more reviewers

@cheddZy cheddZy cheddZy left review comments

@darkexplosiveqwx darkexplosiveqwx darkexplosiveqwx requested changes

@eduqr eduqr eduqr left review comments

@AnkanMisra AnkanMisra AnkanMisra left review comments

@Shriyash-24 Shriyash-24 Shriyash-24 left review comments

@dralan71 dralan71 dralan71 left review comments

@zemiakx zemiakx zemiakx left review comments

@loukhin loukhin loukhin approved these changes

@ferivoq ferivoq ferivoq approved these changes

@Xiang-CH Xiang-CH Xiang-CH approved these changes

@erdemoon erdemoon erdemoon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.