Prevent crash on sigil_prefix and sigil_suffix (OTP 27)
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to conjure up a test 🧙♂️, though this is a very strange occurrence (it's late so I guess I must be sleepy). Without the |
Before it start analysis hank already tries to read files, and is crashing at that moment Since the "wholly ignored" section of the code comes later that the initial analysis that crashes we're left with not using Hank for the time being
paulo-ferraz-oliveira
force-pushed
the
fix/for-otp27
branch
from
7649244
to
476e334
Compare
elbrujohalcon
approved these changes
Jul 1, 2024
| @@ -8,7 +8,7 @@ | |||
| {profiles, | |||
| [{test, [{cover_enabled, true}, {cover_opts, [verbose]}, {ct_opts, [{verbose, true}]}]}]}. | |||
|
|
|||
| {alias, [{test, [compile, format, hank, lint, xref, dialyzer, ct, cover, ex_doc]}]}. | |||
| {alias, [{test, [compile, lint, xref, dialyzer, ct, cover, ex_doc]}]}. | |||
There was a problem hiding this comment.
We should definitely write up a ticket to recover these 2 tools once they incorporate the new katana version we'll create with these changes.
|
Any chance this gets released soon so we can update tools depending on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
rebar3_hankcrashes when trying to analyse a file that containsMissing tests
I can't seem to be able to create a test for this. It's possible there's some type of pre-processing on the input. Please advise.Further considerations
We're using
rebar3_hankin this lib., but that's also crashing due to this lib. We could create a task to re-incorporate it later, if you think it worth it. The same can be done for the formatter, since that's also crashing, even with the-format ignorethat I just removed.