fix: users/:id monthly_supporter_badge only gets returned if the user also prefers_monthly_supporter_badge #541
Open
kfc35 wants to merge 1 commit intoinaturalist:mainfrom
Open
fix: users/:id monthly_supporter_badge only gets returned if the user also prefers_monthly_supporter_badge #541kfc35 wants to merge 1 commit intoinaturalist:mainfrom
kfc35 wants to merge 1 commit intoinaturalist:mainfrom
Conversation
kfc35
commented
Oct 8, 2025
| "monthly_supporter_badge" | ||
| ); | ||
| } else { | ||
| query.field( "false", "monthly_supporter_badge" ); |
Author
There was a problem hiding this comment.
If you’d rather this case return null instead of false, let me know. I originally had it returning null previously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in the github issue:
schema/indices/users.js).monthly_supporter_badgereplacesmonthly_supporterfor the users/:id endpoint, which takes into account whether the user’sprefers_monthly_supporter_badgeis true.users/mekeeps its logic of returningmonthly_supporterregardless ofprefers_monthly_supporter_badgeI implemented the solution as a separate query to the preferences table, but if the team is concerned and prefers it to be left joined to the original user query, that can be arranged.
Closes #479