Open
Conversation
Fixed inability to save * or # into speed dial memories Fixed not returning to normal dialing mode after speed dialing or using * or # characters. Added "hotline" feature that dials contents of memory "0" when going off-hook. Adjustable delay and EEPROM storage. Added adjustable DTMF tone length and EEPROM storage.
Updated hex file with latest feature and bug fix changes
Added generic schematic with added polarity guard circuit and zener diode to assure sufficient voltage at regulator input. Added schematic showing connection points for a Western Electric 5000 desk telephone set. Added text file with recommended fuse settings. Add instructions text file with updates for new features.
… enable/disable Added new slow ascending and slow descending tones to signify feature enable/disable
Update rotarydial_nz.hex
Removed the blue box mode instructions as that mode is not included in this branch.
Overview of changes from Matt's code
|
I know this pull request is really old, but wasn't sure where else to comment, I tried running the Makefile in Don's updated branch and got an error message that |
Author
|
Thanks, I will check my two branches and make the correction as needed. I'm sure my branches compiled fine in the past, but will verify.
inaxeon chose not to incorporate my changes back into his master, so my code exists today as two independent branches. My two versions are well-tested and in-use at my home in over 20 old rotary phones without issue using my updated hardware schematic.
Best,
Don Froula
WD9DMP
On Friday, January 21, 2022, 09:55:44 AM CST, vollmster ***@***.***> wrote:
I know this pull request is really old, but wasn't sure where else to comment, I tried running the Makefile in Don's updated branch and got an error message that DIGIT_TUNE_DESC2 and DIGIT_TUNE_ASC2 were undeclared and missing from the dtmf.h file. In Don's other branch with blue box mode I found that the variables were declared in the dtmf.h file so I copied them over and re-ran the make file without further issues. Anyways, just suggesting for completeness' sake that perhaps the dtmf.h file in this branch could be updated to avoid that error.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Added the following definitions to dtmf.h for clean compilation: #define DIGIT_TUNE_ASC2 -14 #define DIGIT_TUNE_DESC2 -15
Author
|
I confirmed the issue with missing definitions in dtmf.h in my "Feature-additions-and-bug-fixes" branch.
I added the following definitions to dtmf.h:
#define DIGIT_TUNE_ASC2 -14
#define DIGIT_TUNE_DESC2 -15
That branch now compiles cleanly.
Note this is the branch without my Blue Box mode additions, but with the other feature additions and enhancements.
Thanks for the bug report.
Regards,
Don Froula
K9CLF
On Friday, January 21, 2022, 09:55:44 AM CST, vollmster ***@***.***> wrote:
I know this pull request is really old, but wasn't sure where else to comment, I tried running the Makefile in Don's updated branch and got an error message that DIGIT_TUNE_DESC2 and DIGIT_TUNE_ASC2 were undeclared and missing from the dtmf.h file. In Don's other branch with blue box mode I found that the variables were declared in the dtmf.h file so I copied them over and re-ran the make file without further issues. Anyways, just suggesting for completeness' sake that perhaps the dtmf.h file in this branch could be updated to avoid that error.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matt, I forked your latest code and applied my "bug fixes".
This branch off the fork adds hotline and adjustable DTMF digit length.
See README for details.
I made some hardware changes in the schematic to add polarity guard to protect the regulator and a zener to assure sufficient 78L05 input voltage.
Feel free not to pull the changes!
Don