fix(config): Fix openclaw config typo and increase max_tokens_per_mb#959
fix(config): Fix openclaw config typo and increase max_tokens_per_mb#959
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses two minor but impactful adjustments within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request fixes a typo in the total_trian_steps parameter in the openclaw example configuration file and increases the max_tokens_per_mb parameter to improve training throughput. The changes are straightforward and address the described issues.
| seed: 1 | ||
| enable_offload: false | ||
| total_train_epochs: 10 | ||
| total_trian_steps: 100 |
There was a problem hiding this comment.
The original parameter name total_trian_steps contains a typo. This correction ensures that the configuration is correctly parsed and used by the training script.
total_train_steps| gradient_checkpointing: true | ||
| dtype: bfloat16 | ||
| mb_spec: | ||
| max_tokens_per_mb: 10240 |
There was a problem hiding this comment.
Increasing max_tokens_per_mb can improve training throughput by allowing larger microbatches. This change is intended to optimize performance.
max_tokens_per_mb: 15360
…nclusionAI#959) Fix openclaw example config with two corrections: * Fix typo: total_trian_steps -> total_train_steps * Increase max_tokens_per_mb from 10240 to 15360 for better training throughput
…nclusionAI#959) Fix openclaw example config with two corrections: * Fix typo: total_trian_steps -> total_train_steps * Increase max_tokens_per_mb from 10240 to 15360 for better training throughput
2 participants
Description
Fix openclaw example config with two corrections:
total_trian_steps->total_train_stepsmax_tokens_per_mbfrom 10240 to 15360 for better training throughputRelated Issue
N/A
Type of Change
work as expected)
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
N/A
Additional Context
Changed file:
examples/openclaw/config.yamlNeed help? Check the Contributing Guide or ask in
GitHub Discussions!