CROSSLINK-119 Implement archive function #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanisSaldabols
force-pushed
the
CROSSLINK-119
branch
from
32cfd8a to
395e456
Compare
JanisSaldabols
force-pushed
the
CROSSLINK-119
branch
from
d2c6ba5 to
87dccf1
Compare
jakub-id
reviewed
Jun 12, 2025
| located_suppliers JSONB NOT NULL | ||
| ); | ||
|
|
||
| CREATE OR REPLACE FUNCTION archive_ill_transaction_by_date_and_status( |
Contributor
There was a problem hiding this comment.
@JanisSaldabols are there any provisions here to prevent starting two archive functions at the same time?
Collaborator
Author
There was a problem hiding this comment.
Good point
Added DB lock
JanisSaldabols
force-pushed
the
CROSSLINK-119
branch
from
3fb9f44 to
11d51c6
Compare
Contributor
|
@adamdickmeiss I'm wondering if API endpoint is the best interface for this given that HTTP is just not great for modelling async stuff. Initially, I discussed with Janis making a separate binary for this so we can launch it as a Kubernetes CronJob. The really nice thing about this approach is that devops have 100% visibility into it. Thoughts? |
adamdickmeiss
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.