Handler validate supplier #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validate that transaction has a selected supplier when accepting requesting agency message, this avoid cryptic errors logged later when the message cannot be send out by the client
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates error handling for supplier validation by merging multiple error constants into a single, more generic error message and implementing comprehensive supplier validation for requesting agency messages.
- Replaces distinct supplier error constants with a unified
SupplierNotFoundOrInvaliderror - Adds supplier validation logic to requesting agency message handling
- Updates tests to cover new validation scenarios including wrong symbols and skipped suppliers
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| broker/handler/iso18626-handler.go | Consolidates error constants and adds supplier validation to requesting agency message handler |
| broker/client/client.go | Makes broker symbol variable private for consistency |
| broker/test/handler/iso18626-handler_test.go | Updates test assertions and adds comprehensive test cases for supplier validation |
| broker/test/testdata/reqmsg-notification.xml | Adds test data file for notification message testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adamdickmeiss
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.